Code review comment for ~ajorgens/cloud-init:octal-modes

Revision history for this message
Chad Smith (chad.smith) wrote :

Looks good and thanks for the unit tests. Since we now have a with_logs option in CiTest class, let's use that instead of mocks.

Here's a slight extension to our unit test logging setup to also make sure we check log level on some of these logs.
http://paste.ubuntu.com/24843185/

Approved if folks think this is a good idea with the following patch.

review: Approve

« Back to merge proposal