Code review comment for lp:~ajmitch/launchpad/fakesyncs

Revision history for this message
Māris Fogels (mars) wrote :

Hi Andrew,

The branch structure is really difficult to follow. Before landing this I think you have to make absolutely sure that no execution paths have changed. The fact that these scripts often don't have tests does not help the matter: we have to lean even more on code inspection.

Did you have a pre-implementation call with anyone? And are there any tests that can be run to verify the change?

Maris

review: Needs Information

« Back to merge proposal