Code review comment for lp:~ajkavanagh/openstack-mojo-specs/fix-os-project-id-nova-creds

Revision history for this message
Liam Young (gnuoy) wrote :

Alex, a function exists that returns a keystone session object based on the api version. That function is called get_keystone_session. You have amended (admittedly pre-existing) code in get_keystone_client that creates a keystone session object based on the api version. I am suggesting that rather than have logic for getting a keystone session object based on the api version in get_keystone_client, get_keystone_client should call get_keystone_session.

« Back to merge proposal