Juju Charms Collection
keystone package

Code review comment for lp:~ajkavanagh/charms/trusty/keystone/add-service-checks-lp1524388

  1. Trusty Tahr (14.04)
  2. add-service-checks-lp1524388
  3. Merge into next
Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

> One, we have some text conflicts that need to be resolved.

I'm guessing this means some more changes in keystone?

I'm also guessing we need to get the charm-helpers change(s) merged first, then re-sync on keystone (on this one) + any further changes on keystone, and get that in as a merge? Also, did the 'determine_ports()' change alleviate your concerns around ports and HA?

Thanks again for the review :)

« Back to merge proposal