Juju Charms Collection
keystone package

Code review comment for lp:~ajkavanagh/charms/trusty/keystone/add-service-checks-lp1524388

  1. Trusty Tahr (14.04)
  2. add-service-checks-lp1524388
  3. Merge into next
Revision history for this message
David Ames (thedac) wrote :

This looks great. And will be ready to merge after two more steps.

One, we have some text conflicts that need to be resolved.

Two, my manual run of unit tests are failing due to issues not related to your change. I'd like to see the result of the automated run of unit tests so I have moved this from WIP to needs review which should kick that off.

review: Needs Fixing

« Back to merge proposal