Code review comment for lp:~ajeans/bzr/status-callback

> No need to revert, this is just not merged for now. See if you can get it to
> pass the log tests in your branch, then push to Launchpad again and add a note
> on this proposal. If you want help fixing the tests just ask.

Martin,
It is impressive to see pre_merge hooks in action. At least I do not have to feel too guilty if I break something. :)

I updated the branch and tested it with a bigger subset of unit tests (including the one that failed). I also grepped through the tree to make sure I left nothing behind.
I'll let the whole test suite run on my laptop overnight, but last time I tried, it core dumped in the middle of it so I am not entirely sure that it will be useful.

As for the code, its only goal now is to expose status output as a callback (the dead code was not dead yet). However, I will probably have to file a bug regarding the different short outputs between status and log :
status uses ChangeReporter on a change_iterator whereas log uses a method on a TreeDelta. And they disagree on a few things (is short for 'added' a 'N' or a 'A', ...)

Thanks for your patience.