Merge lp:~ajalkane/ubuntu-filemanager-app/remove-bookmark-functionality into lp:ubuntu-filemanager-app

Proposed by Arto Jalkanen
Status: Merged
Approved by: Arto Jalkanen
Approved revision: 33
Merged at revision: 33
Proposed branch: lp:~ajalkane/ubuntu-filemanager-app/remove-bookmark-functionality
Merge into: lp:ubuntu-filemanager-app
Diff against target: 74 lines (+1/-48)
3 files modified
BookmarksPage.qml (+0/-33)
FolderListView.qml (+0/-5)
ubuntu-filemanager-app.qml (+1/-10)
To merge this branch: bzr merge lp:~ajalkane/ubuntu-filemanager-app/remove-bookmark-functionality
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Arto Jalkanen Approve
Review via email: mp+165912@code.launchpad.net

Commit message

Remove Bookmarks functionality (no time for it)

Description of the change

Remove Bookmarks functionality (no time for it)

To post a comment you must log in.
Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Agreed, unless someone else picks up development.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== removed file 'BookmarksPage.qml'
--- BookmarksPage.qml 2013-04-17 17:55:41 +0000
+++ BookmarksPage.qml 1970-01-01 00:00:00 +0000
@@ -1,33 +0,0 @@
1/*
2 * Copyright (C) 2013 Canonical Ltd
3 *
4 * This program is free software: you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License version 3 as
6 * published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU General Public License for more details.
12 *
13 * You should have received a copy of the GNU General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 *
16 * Authored by: Arto Jalkanen <ajalkane@gmail.com>
17 */
18import QtQuick 2.0
19import Ubuntu.Components 0.1
20
21Page {
22 anchors.margins: units.gu(2)
23
24 Column {
25 anchors.centerIn: parent
26 Label {
27 id: label
28 objectName: "label"
29
30 text: i18n.tr("TODO: listing of bookmarks")
31 }
32 }
33}
340
=== modified file 'FolderListView.qml'
--- FolderListView.qml 2013-05-16 19:04:42 +0000
+++ FolderListView.qml 2013-05-27 16:09:45 +0000
@@ -91,11 +91,6 @@
91 property var model91 property var model
92 actions: ActionList {92 actions: ActionList {
93 Action {93 Action {
94 text: i18n.tr("Add as bookmark")
95 // TODO
96 onTriggered: print(text)
97 }
98 Action {
99 text: i18n.tr("Show details")94 text: i18n.tr("Show details")
100 onTriggered: {95 onTriggered: {
101 print(text)96 print(text)
10297
=== modified file 'ubuntu-filemanager-app.qml'
--- ubuntu-filemanager-app.qml 2013-04-17 17:55:41 +0000
+++ ubuntu-filemanager-app.qml 2013-05-27 16:09:45 +0000
@@ -46,15 +46,6 @@
46 // Tab content begins here46 // Tab content begins here
47 page: FolderListPage {47 page: FolderListPage {
48 }48 }
49 }49 }
50
51 // Second tab begins here
52 Tab {
53 objectName: "bookmarksPage"
54
55 title: i18n.tr("Bookmarks")
56 page: BookmarksPage {
57 }
58 }
59 }50 }
60}51}

Subscribers

People subscribed via source and target branches