Merge lp:~aisrael/charms/trusty/juju-gui/fix-automated-testing into lp:~juju-gui/charms/trusty/juju-gui/trunk

Proposed by Richard Harding
Status: Merged
Approved by: Francesco Banconi
Approved revision: 209
Merged at revision: 209
Proposed branch: lp:~aisrael/charms/trusty/juju-gui/fix-automated-testing
Merge into: lp:~juju-gui/charms/trusty/juju-gui/trunk
Diff against target: 49 lines (+16/-0)
2 files modified
config.yaml (+4/-0)
tests/tests.yaml (+12/-0)
To merge this branch: bzr merge lp:~aisrael/charms/trusty/juju-gui/fix-automated-testing
Reviewer Review Type Date Requested Status
Francesco Banconi Pending
Review via email: mp+238103@code.launchpad.net

This proposal supersedes a proposal from 2014-10-08.

Description of the change

Add test.yaml for automated tests.

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote : Posted in a previous version of this proposal

Hi Adam,
thanks a lot for this branch, it looks nice, with just a minor request below.

Also note that lp:charms/juju-gui is the precise release branch of the GUI charm, while the development branch is lp:~juju-gui/charms/trusty/juju-gui/trunk, which is then pushed to both precise and trusty releases. Could you please repropose this against lp:~juju-gui/charms/trusty/juju-gui/trunk? I will take care of making charm releases later, so that we can test the GUI charm again with the bundletester.

review: Approve
Revision history for this message
Richard Harding (rharding) wrote :

I've retarged per Francesco's request using the resubmit proposal tool on the upper right. Francesco, can you double check all looks well and help walk it through the rest of the way please?

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Add test.yaml for automated tests.

Revision history for this message
Francesco Banconi (frankban) wrote :

Thanks again Adam and Rick!
I merged the branch using "lbox submit -adopt".
I'll make a new charm release asap this week.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-04-15 14:17:12 +0000
+++ config.yaml 2014-10-13 06:18:03 +0000
@@ -66,17 +66,20 @@
66 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.66 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.
67 If not, cetificates will be automatically generated.67 If not, cetificates will be automatically generated.
68 type: string68 type: string
69 default:
69 ssl-key-contents:70 ssl-key-contents:
70 description: |71 description: |
71 The contents of the private key file to be used in SSL connections to72 The contents of the private key file to be used in SSL connections to
72 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.73 the GUI. Both ssl-cert-contents and ssl-key-contents must be provided.
73 If not, cetificates will be automatically generated.74 If not, cetificates will be automatically generated.
74 type: string75 type: string
76 default:
75 login-help:77 login-help:
76 description: |78 description: |
77 The help text shown to the user on the login screen. If not provided, a79 The help text shown to the user on the login screen. If not provided, a
78 default message is used, suggesting how to find the login credentials.80 default message is used, suggesting how to find the login credentials.
79 type: string81 type: string
82 default:
80 read-only:83 read-only:
81 description: |84 description: |
82 Whether or not the GUI is in read-only mode. Note that read-only mode is85 Whether or not the GUI is in read-only mode. Note that read-only mode is
@@ -103,6 +106,7 @@
103 If given, the password to use for the environment to immediately106 If given, the password to use for the environment to immediately
104 connect. Do not set unless you understand and accept the risks.107 connect. Do not set unless you understand and accept the risks.
105 type: string108 type: string
109 default:
106 sandbox:110 sandbox:
107 description: |111 description: |
108 Run using an in-memory sandbox rather than a real Juju backend. Sandbox112 Run using an in-memory sandbox rather than a real Juju backend. Sandbox
109113
=== added file 'tests/tests.yaml'
--- tests/tests.yaml 1970-01-01 00:00:00 +0000
+++ tests/tests.yaml 2014-10-13 06:18:03 +0000
@@ -0,0 +1,12 @@
1tests: "[0-9]*"
2reset: false
3packages:
4 - build-essential
5 - bzr
6 - charm-tools
7 - firefox
8 - libapt-pkg-dev
9 - libpython-dev
10 - python-virtualenv
11 - rsync
12 - xvfb

Subscribers

People subscribed via source and target branches

to all changes: