Juju Lint

Merge ~aieri/juju-lint:bug/1807730 into juju-lint:master

  1. Git
  2. lp:~aieri/juju-lint
  3. bug/1807730
  4. Merge into master
Proposed by Andrea Ieri
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: ~aieri/juju-lint:bug/1807730
Merge into: juju-lint:master
Diff against target: 15 lines (+4/-0)
1 file modified
contrib/canonical-rules.yaml (+4/-0)
Reviewer Review Type Date Requested Status
Dan Ackerson (community) Approve
BootStack Reviewers Pending
Review via email: mp+398081@code.launchpad.net

Commit message

Ensure livestatus is enabled
Closes-Bug: 1807730

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Dan Ackerson (dan.ackerson) wrote :

lgtm

review: Approve
Revision history for this message
Andrea Ieri (aieri) wrote :

Back to WIP. We can't add this rule to the default Canonical ruleset since not all environments will be using Thruk.

Either we implement this as an overlay (see bug 1916045), or find a way to make alerting on the absence of livestatus conditional on the presence of the thruk-agent charm.

Unmerged commits

02a6e5c... by Andrea Ieri

Ensure livestatus is enabled

Closes-Bug: 1807730

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
2index 0961671..b3960a5 100644
3--- a/contrib/canonical-rules.yaml
4+++ b/contrib/canonical-rules.yaml
5@@ -62,6 +62,10 @@ config:
6 ntp:
7 auto_peers:
8 eq: true
9+ nagios:
10+ # Necessary for thruk
11+ enable_livestatus:
12+ eq: true
13
14 subordinates:
15 telegraf:

Subscribers

People subscribed via source and target branches