Merge ~aieri/charm-hw-health:bug/1928404 into charm-hw-health:master

Proposed by Andrea Ieri
Status: Merged
Merged at revision: 107ae594539b2ed8d7544eacf2d5a8a6cd6fa9f2
Proposed branch: ~aieri/charm-hw-health:bug/1928404
Merge into: charm-hw-health:master
Diff against target: 26 lines (+9/-3)
1 file modified
src/actions.yaml (+9/-3)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Needs Fixing
Review via email: mp+402730@code.launchpad.net

Commit message

Amend the ack-sel documentation.

Only entries _newer_ than the set date will be considered for alerting.

Closes-bug: 1928404

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/actions.yaml b/src/actions.yaml
index d66df4d..888711d 100644
--- a/src/actions.yaml
+++ b/src/actions.yaml
@@ -11,12 +11,18 @@ show-sel:
11 type: boolean11 type: boolean
12 description: Show all events, not just the non-nominal ones.12 description: Show all events, not just the non-nominal ones.
13ack-sel:13ack-sel:
14 description: |14 description: >
15 Set date filter for ipmi-sel to filter out old logs from ongoing reports.15 The IPMI check alerts whenever entries are present in the SEL.
16
17 This action limits the alerting to entries newer than than the date
18 specified via the 'date' parameter, effectively acknowledging any older
19 entry.
16 params:20 params:
17 date:21 date:
18 type: string22 type: string
19 description: Newer entries than specified date will be left out, format is YYYY-MM-DD (default to now if unspecified)23 description: |
24 Lower threshold for ipmi-sel alerts. The format is YYYY-MM-DD.
25 Defaults to the current date.
20unack-sel:26unack-sel:
21 description: |27 description: |
22 Unset the date filter set by ack-sel action.28 Unset the date filter set by ack-sel action.

Subscribers

People subscribed via source and target branches

to all changes: