Merge ~aieri/charm-hw-health:bug/1928404 into charm-hw-health:master

Proposed by Andrea Ieri
Status: Merged
Merged at revision: 107ae594539b2ed8d7544eacf2d5a8a6cd6fa9f2
Proposed branch: ~aieri/charm-hw-health:bug/1928404
Merge into: charm-hw-health:master
Diff against target: 26 lines (+9/-3)
1 file modified
src/actions.yaml (+9/-3)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Needs Fixing
Review via email: mp+402730@code.launchpad.net

Commit message

Amend the ack-sel documentation.

Only entries _newer_ than the set date will be considered for alerting.

Closes-bug: 1928404

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/actions.yaml b/src/actions.yaml
2index d66df4d..888711d 100644
3--- a/src/actions.yaml
4+++ b/src/actions.yaml
5@@ -11,12 +11,18 @@ show-sel:
6 type: boolean
7 description: Show all events, not just the non-nominal ones.
8 ack-sel:
9- description: |
10- Set date filter for ipmi-sel to filter out old logs from ongoing reports.
11+ description: >
12+ The IPMI check alerts whenever entries are present in the SEL.
13+
14+ This action limits the alerting to entries newer than than the date
15+ specified via the 'date' parameter, effectively acknowledging any older
16+ entry.
17 params:
18 date:
19 type: string
20- description: Newer entries than specified date will be left out, format is YYYY-MM-DD (default to now if unspecified)
21+ description: |
22+ Lower threshold for ipmi-sel alerts. The format is YYYY-MM-DD.
23+ Defaults to the current date.
24 unack-sel:
25 description: |
26 Unset the date filter set by ack-sel action.

Subscribers

People subscribed via source and target branches

to all changes: