Code review comment for lp:~ahayzen/webbrowser-app/migrate-to-tabs-component

Revision history for this message
Olivier Tilloy (osomon) wrote :

The functionality seems to work well. Visually the tabs look very short though, a few pixels taller would make them easier targets for a mouse cursor. That’s stressed by the vertical space between the window title bar and the tabs themselves, which looks too tall to my eye. And when hovering over a non active tab just next to the currently active one, the highlight itself is taller than the current tab, is that intended? (see http://people.canonical.com/~osomon/new-tabs.png)
I guess my question really is: has that been validated by visual design?

« Back to merge proposal