Merge lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent into lp:ubuntu-weather-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 248
Merged at revision: 248
Proposed branch: lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent
Merge into: lp:ubuntu-weather-app
Diff against target: 56 lines (+17/-3)
3 files modified
app/components/CurrentLocation.qml (+6/-0)
debian/changelog (+10/-2)
manifest.json.in (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-weather-app/fix-1602691-osm-geocode-needs-useragent
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+300452@code.launchpad.net

Commit message

* Set useragent in geocode so that osm can uniquely identify our requests

Description of the change

* Set useragent in geocode so that osm can uniquely identify our requests

This fixes the issue of location not being detected within the weather-app.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/components/CurrentLocation.qml'
--- app/components/CurrentLocation.qml 2015-11-02 21:28:34 +0000
+++ app/components/CurrentLocation.qml 2016-07-19 11:33:24 +0000
@@ -65,6 +65,12 @@
65 Plugin {65 Plugin {
66 id: osmPlugin66 id: osmPlugin
67 name: "osm"67 name: "osm"
68
69 // Set a useragent so that osm can uniquely identify out requests
70 PluginParameter {
71 name: "osm.useragent"
72 value: "ubuntu-weather-app"
73 }
68 }74 }
6975
70 GeocodeModel {76 GeocodeModel {
7177
=== modified file 'debian/changelog'
--- debian/changelog 2016-06-05 20:16:22 +0000
+++ debian/changelog 2016-07-19 11:33:24 +0000
@@ -1,4 +1,12 @@
1ubuntu-weather-app (3.3ubuntu1) UNRELEASED; urgency=medium1ubuntu-weather-app (3.4ubuntu1) UNRELEASED; urgency=medium
2
3 [ Andrew Hayzen ]
4 * Set useragent in geocode so that osm can uniquely identify our requests
5 * Release 3.3 and bump version to 3.4
6
7 -- Andrew Hayzen <ahayzen@gmail.com> Tue, 19 Jul 2016 12:22:57 +0100
8
9ubuntu-weather-app (3.3ubuntu1) xenial; urgency=medium
210
3 [ Andrew Hayzen ]11 [ Andrew Hayzen ]
4 * Release 3.2 and bump version to 3.312 * Release 3.2 and bump version to 3.3
@@ -8,7 +16,7 @@
8 * Update to use new weather API16 * Update to use new weather API
9 * Change the trimAPIKey function so it only trims the API Key17 * Change the trimAPIKey function so it only trims the API Key
1018
11 -- Andrew Hayzen <ahayzen@gmail.com> Sat, 04 Jun 2016 18:31:29 +010019 -- Andrew Hayzen <ahayzen@gmail.com> Tue, 19 Jul 2016 12:22:35 +0100
1220
13ubuntu-weather-app (3.2ubuntu1) vivid; urgency=medium21ubuntu-weather-app (3.2ubuntu1) vivid; urgency=medium
1422
1523
=== modified file 'manifest.json.in'
--- manifest.json.in 2016-06-05 20:16:22 +0000
+++ manifest.json.in 2016-07-19 11:33:24 +0000
@@ -12,7 +12,7 @@
12 "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>",12 "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>",
13 "name": "@PROJECT_NAME@",13 "name": "@PROJECT_NAME@",
14 "title": "Weather",14 "title": "Weather",
15 "version": "3.3.@BZR_REVNO@",15 "version": "3.4.@BZR_REVNO@",
16 "x-source": {16 "x-source": {
17 "vcs-bzr": "@BZR_SOURCE@",17 "vcs-bzr": "@BZR_SOURCE@",
18 "vcs-bzr-revno": "@BZR_REVNO@"18 "vcs-bzr-revno": "@BZR_REVNO@"

Subscribers

People subscribed via source and target branches

to all changes: