Code review comment for lp:~ahayzen/music-app/remix-fix-listitemactions-highlight-reordering

Revision history for this message
Victor Thompson (vthompson) wrote :

Now that we are re-adding the reorder support. I'd like the items to have background color as they are reordered. I've never liked how it appears as though just the text is being moved. I think the following is the proper way to do this:

=== modified file 'MusicNowPlaying.qml'
--- MusicNowPlaying.qml 2014-11-07 22:51:16 +0000
+++ MusicNowPlaying.qml 2014-11-15 21:41:44 +0000
@@ -574,7 +574,7 @@
                 id: queueDelegate
                 ListItemWithActions {
                     id: queueListItem
- color: player.currentIndex === index ? "#2c2c34" : "transparent"
+ color: player.currentIndex === index ? "#2c2c34" : mainView.backgroundColor
                     height: queueList.normalHeight
                     objectName: "nowPlayingListItem" + index
                     state: ""

review: Needs Fixing

« Back to merge proposal