Ubuntu Music App

Code review comment for lp:~ahayzen/music-app/remix-defer-loading-pages

  1. remix-defer-loading-pages
  2. Merge into remix
Revision history for this message
Victor Thompson (vthompson) wrote :

A few comments/questions:

1. Should the "Error handling" conditions check for normal equality rather than strict? i.e. == instead of === so 'undefined' might also be matched? Or does createObject() only return 'null' for all error conditions?

2. See small nit pick inline.

review: Needs Fixing

« Back to merge proposal