Merge lp:~ahayzen/music-app/fix-multiselect-lose-focus into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 812
Merged at revision: 813
Proposed branch: lp:~ahayzen/music-app/fix-multiselect-lose-focus
Merge into: lp:music-app/remix
Diff against target: 37 lines (+3/-3)
3 files modified
MusicNowPlaying.qml (+1/-1)
MusicTracks.qml (+1/-1)
common/SongsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-multiselect-lose-focus
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+247547@code.launchpad.net

Commit message

* Fix for multiselect not clearing when losing focus

Description of the change

* Fix for multiselect not clearing when losing focus

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM! Nice simple fix!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'MusicNowPlaying.qml'
--- MusicNowPlaying.qml 2015-01-25 20:04:46 +0000
+++ MusicNowPlaying.qml 2015-01-26 03:27:21 +0000
@@ -469,7 +469,7 @@
469 }469 }
470 onVisibleChanged: {470 onVisibleChanged: {
471 if (!visible) {471 if (!visible) {
472 clearSelection(true)472 closeSelection()
473 }473 }
474 }474 }
475475
476476
=== modified file 'MusicTracks.qml'
--- MusicTracks.qml 2015-01-25 16:44:49 +0000
+++ MusicTracks.qml 2015-01-26 03:27:21 +0000
@@ -181,7 +181,7 @@
181 }181 }
182 onVisibleChanged: {182 onVisibleChanged: {
183 if (!visible) {183 if (!visible) {
184 clearSelection(true)184 closeSelection()
185 }185 }
186 }186 }
187187
188188
=== modified file 'common/SongsPage.qml'
--- common/SongsPage.qml 2015-01-25 16:44:49 +0000
+++ common/SongsPage.qml 2015-01-26 03:27:21 +0000
@@ -283,7 +283,7 @@
283 }283 }
284 onVisibleChanged: {284 onVisibleChanged: {
285 if (!visible) {285 if (!visible) {
286 clearSelection(true)286 closeSelection()
287 }287 }
288 }288 }
289289

Subscribers

People subscribed via source and target branches