Merge lp:~ahayzen/music-app/fix-infographics-1351421 into lp:music-app/trusty

[Andrew Hayzen]

* Fix infographic metric so that it is grammatically correct

* Fix infographic metric so that it is grammatically correct

[Andrew Hayzen (ahayzen)]

Camera App has all lower case 'photos taken today: %d' [0] should we follow or have upper case so "Songs played today: %d" vs "songs played today: %d".

0 - http://bazaar.launchpad.net/~phablet-team/camera-app/trunk/view/head:/camera-app.qml#L171

review: Needs Information

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:549
http://91.189.93.70:8080/job/music-app-ci/970/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1279
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1279/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/194

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/970/rebuild

review: Needs Fixing (continuous-integration)

[Victor Thompson (vthompson)]

I'm confused by this change. It doesn't look like the camera app is using a "photos taken today: %d" format as you suggest. While I agree that it makes the grammatical issue less severe, I think it minimizes the utility of having the data on the welcome screen.

I really think the bug should be fixed in libusermetrics.

review: Needs Information

[Andrew Hayzen (ahayzen)]

Oh yeah there code is not what is happening on my device?!
I have attached a screenshot to prove I'm not mad ;) [0]

0 - https://docs.google.com/file/d/0B3XynHVKfrvMeEsxOHZjOW1lWnM/

[Victor Thompson (vthompson)]

Previously the camera app always had a format similar to ours. I'll see if I can reproduce your results, but I still personally like the way it currently displays the data.

[Victor Thompson (vthompson)]

I see what I typically have seen for the camera infographics on image #169's camera app: http://i.imgur.com/Fzi62x8.png

[Alan Pope 🍺🐧🐱 🦄 (popey)]

The latest camera app on #178 has indeed changed.

http://imgur.com/tH9iGDD - photos taken today: 1
http://imgur.com/zy2oCEe - 1 songs played today

[David Planella (dpm)]

I'd argue that that's a bug in the camera app

[Victor Thompson (vthompson)]

I still see "1 photos taken today" on image #178 while using the camera app. Is it possible that a different app is make the "photos taken today: 1" entry?

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Someone has fudged it in the translation which explains why neither of you see it.

camera-app.qml: format: i18n.tr("<b>%1</b> photos taken today")
camera-app.qml: emptyFormat: i18n.tr("No photos taken today")

po/en_GB.po:msgid "<b>%1</b> photos taken today"
po/en_GB.po:msgstr "photos taken today: <b>%1</b>"
po/en_GB.po:msgid "No photos taken today"
po/en_GB.po:msgstr "No photos taken today"

[David Planella (dpm)]

I'd be for fixing the translation and keep consistency with other apps, so I suggest rejecting the branch. In any case, thanks Andrew, and if you think we need to reconsider it, feel free to revert my status change.

review: Disapprove

Unmerged revisions

549. By Andrew Hayzen on 2014-08-04

* Fix infographic metric so that it is grammatically correct

=== modified file 'music-app.qml'
--- music-app.qml	2014-07-29 00:59:12 +0000
+++ music-app.qml	2014-08-04 19:23:12 +0000
@@ -289,7 +289,7 @@
         id: songsMetric
         name: "music-metrics"
         // TRANSLATORS: this refers to a number of songs greater than one. The actual number will be prepended to the string automatically (plural forms are not yet fully supported in usermetrics, the library that displays that string)
-        format: "<b>%1</b> " + i18n.tr("songs played today")
+        format: i18n.tr("songs played today") + ": <b>%1</b>"
         emptyFormat: i18n.tr("No songs played today")
         domain: "com.ubuntu.music"
     }