Code review comment for lp:~ahayzen/music-app/fix-canload-false-queueloaderworker

Revision history for this message
Victor Thompson (vthompson) wrote :

I've managed to break the timing/race condition part of the fix.

Before a large queue is loaded I play an album containing "Song 2" by the Blur: http://i.imgur.com/9UvRrrw.png. However, when I switch to the queue I see that the queue contains the original large list: http://i.imgur.com/FFBJXR6.png. When I restart the app I get the correct queue (Song 2).

The above might have been a really tight race condition though. I haven't been able to reproduce it more than just once.

review: Needs Information

« Back to merge proposal