Merge lp:~ahayzen/music-app/fix-1538838-export-long-press into lp:music-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 978
Merged at revision: 977
Proposed branch: lp:~ahayzen/music-app/fix-1538838-export-long-press
Merge into: lp:music-app
Diff against target: 57 lines (+12/-5)
3 files modified
app/components/Delegates/MusicListItem.qml (+8/-5)
app/ui/ContentHubExport.qml (+1/-0)
debian/changelog (+3/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-1538838-export-long-press
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Victor Thompson Approve
Review via email: mp+287260@code.launchpad.net

Commit message

* Fix for bug 1538838 so that a press and hold cannot disable selection in the ContentHubExport.qml

Description of the change

* Fix for bug 1538838 so that a press and hold cannot disable selection in the ContentHubExport.qml

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

lgtm! Thanks! :)

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/components/Delegates/MusicListItem.qml'
--- app/components/Delegates/MusicListItem.qml 2016-02-26 00:17:02 +0000
+++ app/components/Delegates/MusicListItem.qml 2016-02-26 03:18:42 +0000
@@ -32,6 +32,7 @@
32 property alias imageSource: image.imageSource32 property alias imageSource: image.imageSource
3333
34 property bool multiselectable: false34 property bool multiselectable: false
35 property bool pressAndHoldEnabled: true
35 property bool reorderable: false36 property bool reorderable: false
3637
37 property alias subtitle: listItemLayout.subtitle38 property alias subtitle: listItemLayout.subtitle
@@ -48,12 +49,14 @@
48 }49 }
4950
50 onPressAndHold: {51 onPressAndHold: {
51 if (reorderable) {52 if (pressAndHoldEnabled) {
52 ListView.view.ViewItems.dragMode = !ListView.view.ViewItems.dragMode53 if (reorderable) {
53 }54 ListView.view.ViewItems.dragMode = !ListView.view.ViewItems.dragMode
55 }
5456
55 if (multiselectable) {57 if (multiselectable) {
56 ListView.view.ViewItems.selectMode = !ListView.view.ViewItems.selectMode58 ListView.view.ViewItems.selectMode = !ListView.view.ViewItems.selectMode
59 }
57 }60 }
58 }61 }
5962
6063
=== modified file 'app/ui/ContentHubExport.qml'
--- app/ui/ContentHubExport.qml 2016-01-29 04:05:56 +0000
+++ app/ui/ContentHubExport.qml 2016-02-26 03:18:42 +0000
@@ -140,6 +140,7 @@
140 height: units.gu(7)140 height: units.gu(7)
141 imageSource: {"art": model.art}141 imageSource: {"art": model.art}
142 multiselectable: true142 multiselectable: true
143 pressAndHoldEnabled: false // Block PressAndHold from working
143 subtitle {144 subtitle {
144 text: model.author145 text: model.author
145 }146 }
146147
=== modified file 'debian/changelog'
--- debian/changelog 2016-02-26 00:17:02 +0000
+++ debian/changelog 2016-02-26 03:18:42 +0000
@@ -7,6 +7,9 @@
7 * Ensure that only one ContentHubExport page is open (LP: #1538863).7 * Ensure that only one ContentHubExport page is open (LP: #1538863).
8 * Fix fallback image path in MusicListItem (LP: #1549580).8 * Fix fallback image path in MusicListItem (LP: #1549580).
99
10 [ Andrew Hayzen ]
11 * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)
12
10 -- Victor <victor@victor-virtual-machine> Wed, 27 Jan 2016 19:40:55 -060013 -- Victor <victor@victor-virtual-machine> Wed, 27 Jan 2016 19:40:55 -0600
1114
12music-app (2.3) vivid; urgency=medium15music-app (2.3) vivid; urgency=medium

Subscribers

People subscribed via source and target branches