Merge lp:~ahayzen/music-app/fix-1407814-save-order-correctly into lp:music-app/remix
Proposed by
Andrew Hayzen
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Victor Thompson | ||||
Approved revision: | 777 | ||||
Merged at revision: | 778 | ||||
Proposed branch: | lp:~ahayzen/music-app/fix-1407814-save-order-correctly | ||||
Merge into: | lp:music-app/remix | ||||
Diff against target: |
208 lines (+65/-35) 2 files modified
meta-database.js (+63/-32) music-app.qml (+2/-3) |
||||
To merge this branch: | bzr merge lp:~ahayzen/music-app/fix-1407814-save-order-correctly | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Victor Thompson | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+245615@code.launchpad.net |
Commit message
* Fix for incorrect saving of queue
Description of the change
* Fix for incorrect saving of queue
The code used to start at index number 1, this has now been fixed so it starts at 0, which caused reordering/removals later on to break.
There is the potential that the queue may already be corrupted (or start at 1 instead of 0), this will remain 'corrupt' until the user clears the queue or selects to play an album (which clears the queue first) etc.
To post a comment you must log in.
PASSED: Continuous integration, rev:771 91.189. 93.70:8080/ job/music- app-ci/ 1179/ 91.189. 93.70:8080/ job/generic- mediumtests- vivid/558 91.189. 93.70:8080/ job/generic- mediumtests- vivid/558/ artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-vivid- amd64-ci/ 31
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 1179/rebuild
http://