Merge lp:~ahayzen/music-app/fix-1383870-scroll-close-actions into lp:music-app/remix

Proposed by Andrew Hayzen
Status: Merged
Approved by: Victor Thompson
Approved revision: 773
Merged at revision: 773
Proposed branch: lp:~ahayzen/music-app/fix-1383870-scroll-close-actions
Merge into: lp:music-app/remix
Diff against target: 15 lines (+5/-0)
1 file modified
common/ListItemWithActions.qml (+5/-0)
To merge this branch: bzr merge lp:~ahayzen/music-app/fix-1383870-scroll-close-actions
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+245996@code.launchpad.net

Commit message

* Reset swipe when flicking view (currently ignores if you flick by touching the swiped listitem)

Description of the change

* Reset swipe when flicking view (currently ignores if you flick by touching the swiped listitem)

Currently if you scroll by touching the currently swiped listitem it will not be reset, this aligns us with the SDK and other system app behaviours.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/ListItemWithActions.qml'
--- common/ListItemWithActions.qml 2014-11-20 01:08:37 +0000
+++ common/ListItemWithActions.qml 2015-01-09 18:30:38 +0000
@@ -261,6 +261,11 @@
261 Connections { // CUSTOM261 Connections { // CUSTOM
262 target: root.parent.parent262 target: root.parent.parent
263 onClearSelection: selected = false263 onClearSelection: selected = false
264 onFlickingChanged: {
265 if (root.parent.parent.flicking) {
266 root.resetSwipe()
267 }
268 }
264 onSelectAll: selected = true269 onSelectAll: selected = true
265 onStateChanged: selectionMode = root.parent.parent.state === "multiselectable"270 onStateChanged: selectionMode = root.parent.parent.state === "multiselectable"
266 }271 }

Subscribers

People subscribed via source and target branches