Code review comment for lp:~ahayzen/music-app/fix-1369050-content-hub-fix-translations

Revision history for this message
Victor Thompson (vthompson) wrote :

1) Aren't we expecting "Music" to always be the name of the music directory regardless of what the locale is? If not, shouldn't we use a system call to determine the name of the folder? I do not think it should be left up to the translator to determine what the name of this folder is.

2) Why are we putting imported files into a deeper folder layout? Personally, I liked having all the imported files in one place. But I can see how this might be overwhelming if we import multiple files at a time.

review: Needs Fixing

« Back to merge proposal