Code review comment for lp:~ahayzen/music-app/ap-helper-refactor-003

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM as well, this is a lot of churn, and we can always tweak once it's done. I trust you :-)

My one request is to look at the number of wait_select's you are using and make sure you really need a wait_select. If the test fails without a wait, look to figure out why before tossing one in there :-)

review: Approve

« Back to merge proposal