Code review comment for lp:~ahayzen/music-app/add-sdk-search-support-002

Revision history for this message
Victor Thompson (vthompson) wrote :

I agree, I don't think we should block on lp:1408481.

One behavioral thing I've noticed is that I think that if the user does the following:
1) clicks search (say from the Artists tab)
2) selects an artist
3) taps the back button to return to Artists
When the user returns to the Artists tab the search bar is still shown and the keyboard is activated. I think the search action should be cancelled when the user leaves the view. Same thing happens when you search for a song and play it. When you return from the Now Playing page the search function is active. I think it should move from the "search" state to the "default" state.

Why have you left out Genres from search? Maybe Playlists would be nice as well--but I see some difficulty there (but it might be nice to search for the playlist you want to add a track to via MusicaddtoPlaylist).

review: Needs Fixing

« Back to merge proposal