Ubuntu
ubuntu-advantage-tools package

Code review comment for ~ahasenack/ubuntu/+source/ubuntu-advantage-tools:disco-v18-update

  1. Git
  2. lp:~ahasenack/ubuntu/+source/ubuntu-advantage-tools
  3. disco-v18-update
  4. Merge into ubuntu/devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Considering that the content was already reviewed on the actual project I can't find an issue from the packaging perspective.
So Ack?

I took a look at the rest (high level only) and found a few worth to mention:

I was wondering why the Readme.md didn't get an entry for "Canonical CIS Ubuntu Benchmark Audit tool", but all other elements got one - intentional?

Furthermore "FIPS PPA repository" got changed to "FIPS repository", but all the commoncriteria/CIS entries still call it "PPA repository" that feels a bit inconsistent.

How do you want to continue, do you want to fix up the mentioned issues and/or a deeper review of what was changed upstream?
Or would you want to upload v18 as-is (it is a correctly packaged v18) and work on those things fro v19 at the source?

review: Needs Information

« Back to merge proposal