Code review comment for ~ahasenack/ubuntu/+source/squid:fix-rotate-assertion-1794553

The integration of the change LGTM, but I wonder if "The FD report in Cache Manager will not have the cache.log entry after that change IIRC. If that fix is adopted, more code changes might be needed to polish the isolation of the debugging API from FD registration." will be a problem.

We'd need a squid power user to get an answer for that but I'm none.

OTOH upstream called it "No known serious problems as far as Squid functionality is concerned" while the total inability to rotate logs is a serious issue for sure.

So reviewing in a hurry and +0.95?
Maybe rbasak has time for a second look.