Code review comment for ~ahasenack/ubuntu/+source/sg3-utils:eoan-sg3-utils-1.44-merge

Revision history for this message
Bryce Harrington (bryce) wrote :

Unrelated to the merge, but in taking a look at the bugs reported against sg3-utils:

* https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/992128
  - Claims that --readonly doesn't work.
  - This is old, filed in 2012, and never really got triaged.
  - Google isn't showing this as a widespread issue, or one that is known/persisting.
  - I bet it is obsolete (possibly usage error?) and can be closed.

* https://bugs.launchpad.net/ubuntu/+source/sg3-utils/+bug/1679392
  - Missing dep8 tests
  - This package doesn't seem like a good autopkgtest candidate since its HW dependent and just cli tools. However, I added thoughts to the bug on some basic tests that could be added.

« Back to merge proposal