Since I imagine you're trying to get this in quickly, this is a very expedient review. The test results seem to be coming in ok:
* Results:
- samba/2:4.18.6+dfsg-1ubuntu1~ppa2
+ ✅ samba on mantic for amd64 @ 17.08.23 16:38:06 Log️ 🗒️
+ ✅ samba on mantic for armhf @ 17.08.23 15:46:05 Log️ 🗒️
+ ✅ samba on mantic for ppc64el @ 17.08.23 16:13:59 Log️ 🗒️
+ ✅ samba on mantic for s390x @ 17.08.23 16:04:16 Log️ 🗒️
* Running:
# time pkg release arch ppa trigger
- 1314 samba mantic arm64 ahasenack/samba-mantic-merge samba/2:4.18.6+dfsg-1ubuntu1~ppa2
* Waiting: (none)
Packaging all looks fine.
A LP # for the various 386 delta would be useful in order to keep track of if/when that can be dropped, and the general status/expectation of Samba support for arch i386, but that's super unimportant for this merge and can be in the "maybe someday" pile.
Cutting FF close I see :-)
Since I imagine you're trying to get this in quickly, this is a very expedient review. The test results seem to be coming in ok:
* Results: 4.18.6+ dfsg-1ubuntu1~ ppa2 samba-mantic- merge samba/2: 4.18.6+ dfsg-1ubuntu1~ ppa2
- samba/2:
+ ✅ samba on mantic for amd64 @ 17.08.23 16:38:06 Log️ 🗒️
+ ✅ samba on mantic for armhf @ 17.08.23 15:46:05 Log️ 🗒️
+ ✅ samba on mantic for ppc64el @ 17.08.23 16:13:59 Log️ 🗒️
+ ✅ samba on mantic for s390x @ 17.08.23 16:04:16 Log️ 🗒️
* Running:
# time pkg release arch ppa trigger
- 1314 samba mantic arm64 ahasenack/
* Waiting: (none)
Packaging all looks fine.
A LP # for the various 386 delta would be useful in order to keep track of if/when that can be dropped, and the general status/expectation of Samba support for arch i386, but that's super unimportant for this merge and can be in the "maybe someday" pile.
Rest LGTM, +1