Code review comment for ~ahasenack/ubuntu/+source/samba:kinetic-samba-416-merge

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> - helper programs moved from /usr/lib/$arch to /usr/libexec
> OK. I just wanted to double check whether the current supported FHS version includes
> /usr/libexec/ and it does (since 2018, in fact). I do remember seeing some lintian warnings with
> /usr/libexec/ previously, but it's been a while.

The lintian output on this package with -I is a "party", and takes about 5min to run. There was nothing specific about libexec indeed.

Thanks for the careful review of the profiling option. I hadn't gone that deep into it myself.

> - We've talked about this, but I don't know if you're planning to rebase your work against the
> latest uploads made by the Debian maintainer.

I have to, launchpad ingested them now ;)

> - It looks like LP #1807177 could/should be closed with this merge.

I was going to close these:
- #1846947: no profiling support
- #1971256: the merge bug

Thanks for finding #1807177, the gluster one I forgot to close during jammy.

« Back to merge proposal