Code review comment for ~ahasenack/ubuntu/+source/samba:jammy-ctdb-nfs-mvp-fixes

Revision history for this message
Miriam EspaƱa Acebal (mirespace) wrote :

Hi Andreas,

intense merge proposal! As spoken, I did a review of the code without testing itself, checking for typos or missed things and trying to understand the a bit the logic.

I don't find any strange. At the beginning, the changes around nfs-kernel-server files confuse me a bit because I was seeing service and conf didn't match or removed but after reading carefully your "# ctdb "service" name" I totally agree that is out of the scope of this MP.

Also, I checked that the new files are shipped in the *.deb from your PPA (I've checked what I might have forgotten).

Thanks for this MP.

review: Approve

« Back to merge proposal