Code review comment for ~ahasenack/ubuntu/+source/samba:groovy-samba-4.12.2-update

> This is no merge of the latest Debian but the latest upstream.
> So our usual changelog-templates don't 100% apply, never the less
> I'd have expected the three dropped patches under a "* Dropped"
> section to spot them more easily. This is an unimportant style
> thing, so it is up to you if you want to change it.

Done

> 4.12 says "GnuTLS 3.4.7 required" and in fact later bumps that to 3.6.5
> for some extras.
> Build dep libgnutls28-dev is unversioned at the moment for the potential
> that people might backport it to bionic (3.5.18) adding a >=3.6.5 might
> be useful - what do you think?

Agreed and done

> Note: the SMB3 speed improvements out of using tls might be worth a
> release not entry for gorilla what do you think?

Yes if confirmed :) How would I make sure to not forget, this early in the cycle? Maybe a release notes bug task, and a card in our merges board collecting all such tasks? I'll do it

> Do you want to check samba conf on upgrade an warn for removed options
> like "write cache size" ?

The samba packaging never did such a thing, at most testparm(1) is run and it will warn and/or fail.

> Again I was wondering about some build issues related to pidl:

I'll see what I can find about these.