Code review comment for ~ahasenack/ubuntu/+source/samba:groovy-samba-4.12.2-update

sssd 2.2.3 is building, and the basics are working, but it doesn't fully work with active directory when using samba 4.12. sssd upstream will make a new release when these land:

https://github.com/SSSD/sssd/pull/999
https://github.com/SSSD/sssd/pull/844
https://github.com/SSSD/sssd/pull/1005

Additionally master already has two commits for samba 4.12:
commit c031adde4f532f39845a0efd78693600f1f8b2f4
Author: Noel Power <email address hidden>
Date: Tue Mar 24 18:14:34 2020 +0000

    ad_gpo_ndr.c: refresh ndr_ methods from samba-4.12

    Signed-off-by: Noel Power <email address hidden>

    Reviewed-by: Pavel Březina <email address hidden>

commit 1fdd8fa2fded1985fbfc6aa67394eebcdbb6a2fc
Author: Noel Power <email address hidden>
Date: Tue Mar 24 13:37:07 2020 +0000

    Use ndr_pull_steal_switch_value for modern samba versions

    commit bc56b10aea999284458dcc293b54cf65288e325d attempted to
    fix the build error resulting from removal of 'ndr_pull_get_switch'

    This change uses the new replacement method
    'ndr_pull_steal_switch_value' however depending on the samba version
    the ndr_pull_steal_switch_value abi is different.

    Note: ndr_pull_steal_switch_value is used since samba 4.10 for
          the affected methods

    Note: the following methods have been refreshed from samba-4.12 generated
          code;

        o ndr_pull_security_ace_object_type
        o ndr_pull_security_ace_object_inherited_type
        o ndr_pull_security_ace_object_ctr

    Signed-off-by: Noel Power <email address hidden>

    Reviewed-by: Pavel Březina <email address hidden>

I could pull these in, but since more are coming, and the builds and dep8 tests we have are find, I would rather leave that for sssd 2.2.4.