Code review comment for ~ahasenack/ubuntu/+source/samba:cosmic-samba-merge-4.8-1778125

Christian Ehrhardt  (paelzer) wrote :

With your logrotate and syslog changes in Debian this looks even better :-)
Tests are good - I checked a bit on my own and the links are as you said onle the gvfs which doesn't matter.

The corner case issue we found in testing really should not stop all these new things from going in. And we have plenty of time to work on that once upstream replies on your bugs.

So what is the state now - still as approved as before?

review: Approve

« Back to merge proposal