Code review comment for ~ahasenack/ubuntu/+source/qemu:noble-qemu-gluster-universe

qemu-amd64-block-extra-and-supplemental.txt
Fresh install of qemu-block-extra 1:8.2.0+ds-4ubuntu1
$ find /usr/lib/x86_64-linux-gnu/qemu/ -name 'block-*.so' -exec md5sum {} \;
0803f89eccacddcc8c77ad4a33868a0d /usr/lib/x86_64-linux-gnu/qemu/block-curl.so
a8378e4dc52e331be3b9b53053d44794 /usr/lib/x86_64-linux-gnu/qemu/block-dmg-bz2.so
0dcb383eecf5f75c4ca34ee6a46f659a /usr/lib/x86_64-linux-gnu/qemu/block-gluster.so
f7fa07b9951df26d18f3026a73b564ca /usr/lib/x86_64-linux-gnu/qemu/block-iscsi.so
97745997a602cff58e492611e7a61920 /usr/lib/x86_64-linux-gnu/qemu/block-nfs.so
801719053ad0f1b54de277583e6d03fc /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
527c297bc4be684cdcb0a7de9afd3e2b /usr/lib/x86_64-linux-gnu/qemu/block-ssh.so

Mount dir mounted, but empty:
$ find /run/qemu/ -type f -name 'block-*.so' -exec md5sum {} \;
$

Installing qemu-block-supplemental 1:8.2.0+ds-4ubuntu2~ppa5:
$ find /usr/lib/x86_64-linux-gnu/qemu/ -name 'block-*.so' -exec md5sum {} \;
aa6fafc7e2c16859cb63758776545285 /usr/lib/x86_64-linux-gnu/qemu/block-curl.so
e105e7859f9cb0fedc1398703b15162b /usr/lib/x86_64-linux-gnu/qemu/block-dmg-bz2.so
f745fa1959b51f995a7dd0b42d802c1e /usr/lib/x86_64-linux-gnu/qemu/block-iscsi.so
008e00f454a668e1881a33a698651075 /usr/lib/x86_64-linux-gnu/qemu/block-nfs.so
5c0d605aa07aa3fc0fe29610d145cf8b /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
71bdbbeecb3fd5b768a886198c216975 /usr/lib/x86_64-linux-gnu/qemu/block-ssh.so
fae53b01d85c97b9eaec0942c2fe40b6 /usr/lib/x86_64-linux-gnu/qemu/block-gluster.so

mount dir contains backup of previous modules, including gluster (which was in -extra back then):
$ find /run/qemu/ -type f -name 'block-*.so' -exec md5sum {} \;
527c297bc4be684cdcb0a7de9afd3e2b /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-ssh.so
801719053ad0f1b54de277583e6d03fc /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-rbd.so
97745997a602cff58e492611e7a61920 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-nfs.so
f7fa07b9951df26d18f3026a73b564ca /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-iscsi.so
0dcb383eecf5f75c4ca34ee6a46f659a /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-gluster.so
a8378e4dc52e331be3b9b53053d44794 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-dmg-bz2.so
0803f89eccacddcc8c77ad4a33868a0d /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-curl.so

Upgrading to qemu-block-supplemental 1:8.2.0+ds-4ubuntu3~ppa5:
$ find /usr/lib/x86_64-linux-gnu/qemu/ -name 'block-*.so' -exec md5sum {} \;
a603df1ea6af2ddd52154c11198110aa /usr/lib/x86_64-linux-gnu/qemu/block-gluster.so
9220b566485b42976d64e6cba6219915 /usr/lib/x86_64-linux-gnu/qemu/block-curl.so
3dd4d675fa5e1385cc9761743235668d /usr/lib/x86_64-linux-gnu/qemu/block-dmg-bz2.so
ee5d2eb371769082bf2da5893489c2ba /usr/lib/x86_64-linux-gnu/qemu/block-iscsi.so
aaa653ddfe204e5473fd1d1d1b9da86f /usr/lib/x86_64-linux-gnu/qemu/block-nfs.so
cfa95525f005f866b4a876f6d863e8e7 /usr/lib/x86_64-linux-gnu/qemu/block-rbd.so
5c3297af66f82374b40e4d27be53743b /usr/lib/x86_64-linux-gnu/qemu/block-ssh.so

mount dir now has new backup of the 4ubuntu2 modules:
$ find /run/qemu/ -type f -name 'block-*.so' -exec md5sum {} \;
71bdbbeecb3fd5b768a886198c216975 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-ssh.so
5c0d605aa07aa3fc0fe29610d145cf8b /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-rbd.so
008e00f454a668e1881a33a698651075 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-nfs.so
f745fa1959b51f995a7dd0b42d802c1e /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-iscsi.so
e105e7859f9cb0fedc1398703b15162b /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-dmg-bz2.so
aa6fafc7e2c16859cb63758776545285 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-curl.so
fae53b01d85c97b9eaec0942c2fe40b6 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-gluster.so
527c297bc4be684cdcb0a7de9afd3e2b /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-ssh.so
801719053ad0f1b54de277583e6d03fc /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-rbd.so
97745997a602cff58e492611e7a61920 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-nfs.so
f7fa07b9951df26d18f3026a73b564ca /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-iscsi.so
0dcb383eecf5f75c4ca34ee6a46f659a /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-gluster.so
a8378e4dc52e331be3b9b53053d44794 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-dmg-bz2.so
0803f89eccacddcc8c77ad4a33868a0d /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-curl.so

Removing qemu-block-extra clears everything up, in the right order:
Do you want to continue? [Y/n]
(Reading database ... 49766 files and directories currently installed.)
Removing qemu-block-supplemental (1:8.2.0+ds-4ubuntu3~ppa5) ...
Removing qemu-block-extra (1:8.2.0+ds-4ubuntu3~ppa5) ...

$ find /usr/lib/x86_64-linux-gnu/qemu/ -name 'block-*.so' -exec md5sum {} \;
$

mount dir still has modules:
$ find /run/qemu/ -type f -name 'block-*.so' -exec md5sum {} \;
71bdbbeecb3fd5b768a886198c216975 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-ssh.so
5c0d605aa07aa3fc0fe29610d145cf8b /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-rbd.so
008e00f454a668e1881a33a698651075 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-nfs.so
f745fa1959b51f995a7dd0b42d802c1e /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-iscsi.so
e105e7859f9cb0fedc1398703b15162b /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-dmg-bz2.so
aa6fafc7e2c16859cb63758776545285 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-curl.so
fae53b01d85c97b9eaec0942c2fe40b6 /run/qemu/Debian_1_8.2.0+ds-4ubuntu2~ppa5/block-gluster.so
527c297bc4be684cdcb0a7de9afd3e2b /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-ssh.so
801719053ad0f1b54de277583e6d03fc /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-rbd.so
97745997a602cff58e492611e7a61920 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-nfs.so
f7fa07b9951df26d18f3026a73b564ca /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-iscsi.so
0dcb383eecf5f75c4ca34ee6a46f659a /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-gluster.so
a8378e4dc52e331be3b9b53053d44794 /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-dmg-bz2.so
0803f89eccacddcc8c77ad4a33868a0d /run/qemu/Debian_1_8.2.0+ds-4ubuntu1/block-curl.so

It only gets cleared if the action is purge:
$ cat /var/lib/dpkg/info/qemu-block-extra.postrm
#!/bin/sh
set -e
case $1 in (remove) for m in /usr/lib/x86_64-linux-gnu/qemu/block-*.so; do if echo "block-gluster.so" | grep -qF `basename "$m"`; then continue; else rm -f /run/qemu/Debian_1_8.2.0+ds-4ubuntu3~ppa5/`basename $m`; fi; done;; esac
case $1 in (purge) if systemctl is-active -q run-qemu.mount; then systemctl stop run-qemu.mount || true; fi; rm -rf "/run/qemu";; esac

The following packages will be REMOVED:
  qemu-block-extra*
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n]
(Reading database ... 49754 files and directories currently installed.)
Purging configuration files for qemu-block-extra (1:8.2.0+ds-4ubuntu3~ppa5) ...
Warning: The unit file, source configuration file or drop-ins of run-qemu.mount changed on disk. Run 'systemctl daemon-reload' to reload units.

$ find /run/qemu/ -type f -name 'block-*.so' -exec md5sum {} \;
find: ‘/run/qemu/’: No such file or directory