Merge ~ahasenack/ubuntu/+source/python-opcua:jammy-py310-collections-import into ubuntu/+source/python-opcua:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 9c87914fcc2f8e940d602fa16a683bd157a283db
Proposed branch: ~ahasenack/ubuntu/+source/python-opcua:jammy-py310-collections-import
Merge into: ubuntu/+source/python-opcua:ubuntu/devel
Diff against target: 79 lines (+45/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/0005-fix-collections-import.patch (+35/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server Pending
Review via email: mp+415054@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for forwarding patch to Debian. Packaging and technical changes look proper.
Builds and autopkgtests successfully locally as well as via bileto:

Results from https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ahasenack-py310-collections/?format=plain:
  python-opcua @ amd64:
    03.02.22 23:36:31 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ arm64:
    03.02.22 23:37:04 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ armhf:
    03.02.22 23:39:49 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ ppc64el:
    03.02.22 23:37:37 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ s390x:
    03.02.22 23:36:10 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅

LGTM, +1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks Bryce, uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index e3e45fe..2e4274d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1python-opcua (0.98.11-1ubuntu1) jammy; urgency=medium
2
3 * d/p/0005-fix-collections-import.patch: fix collections import for
4 python 3.10+ (LP: #1959935)
5
6 -- Andreas Hasenack <andreas@canonical.com> Thu, 03 Feb 2022 20:22:48 +0000
7
1python-opcua (0.98.11-1) unstable; urgency=medium8python-opcua (0.98.11-1) unstable; urgency=medium
29
3 * Team upload10 * Team upload
diff --git a/debian/control b/debian/control
index 9ec8109..02e3d1f 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: python-opcua1Source: python-opcua
2Section: python2Section: python
3Priority: optional3Priority: optional
4Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
5Uploaders: W. Martin Borgert <debacle@debian.org>6Uploaders: W. Martin Borgert <debacle@debian.org>
6Build-Depends: devscripts,7Build-Depends: devscripts,
7 python3,8 python3,
diff --git a/debian/patches/0005-fix-collections-import.patch b/debian/patches/0005-fix-collections-import.patch
8new file mode 1006449new file mode 100644
index 0000000..61ffa34
--- /dev/null
+++ b/debian/patches/0005-fix-collections-import.patch
@@ -0,0 +1,35 @@
1From 34d98f992f9f7e494be20f028cdf9a05b3b62540 Mon Sep 17 00:00:00 2001
2From: Nick James <20824939+driftregion@users.noreply.github.com>
3Date: Fri, 19 Jun 2020 03:56:17 +0800
4Subject: [PATCH] remove DeprecationWarning: import Iterable from
5 collections.abc if python >= 3.6 (#1075)
6
7Co-authored-by: Nick James <nick.james@dorabot.com>
8---
9 opcua/common/subscription.py | 6 +++++-
10 1 file changed, 5 insertions(+), 1 deletion(-)
11
12Origin: upstream, https://github.com/FreeOpcUa/python-opcua/commit/34d98f992f9f7e494be20f028cdf9a05b3b62540
13Bug: https://github.com/FreeOpcUa/python-opcua/pull/1075
14Bug-Debian: https://bugs.debian.org/1004937
15Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/python-opcua/+bug/1959935
16Applied-Upstream: 0.98.12
17Last-Update: 2022-02-03
18
19diff --git a/opcua/common/subscription.py b/opcua/common/subscription.py
20index 19b8d1a8..defbafb0 100644
21--- a/opcua/common/subscription.py
22+++ b/opcua/common/subscription.py
23@@ -4,7 +4,11 @@
24 import time
25 import logging
26 from threading import Lock
27-from collections import Iterable
28+import sys
29+if sys.version_info.major == 3 and sys.version_info.minor >= 6:
30+ from collections.abc import Iterable
31+else:
32+ from collections import Iterable
33
34 from opcua import ua
35 from opcua.common import events
diff --git a/debian/patches/series b/debian/patches/series
index 4cab713..f7e7f15 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
1add-shebang.patch1add-shebang.patch
20003-Use-the-python3-binary-in-cmdline-tests.patch20003-Use-the-python3-binary-in-cmdline-tests.patch
30004-Fix-comparison-with-literal.patch30004-Fix-comparison-with-literal.patch
40005-fix-collections-import.patch

Subscribers

People subscribed via source and target branches