Merge ~ahasenack/ubuntu/+source/python-opcua:jammy-py310-collections-import into ubuntu/+source/python-opcua:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Merged at revision: 9c87914fcc2f8e940d602fa16a683bd157a283db
Proposed branch: ~ahasenack/ubuntu/+source/python-opcua:jammy-py310-collections-import
Merge into: ubuntu/+source/python-opcua:ubuntu/devel
Diff against target: 79 lines (+45/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/0005-fix-collections-import.patch (+35/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server Pending
Review via email: mp+415054@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for forwarding patch to Debian. Packaging and technical changes look proper.
Builds and autopkgtests successfully locally as well as via bileto:

Results from https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ahasenack-py310-collections/?format=plain:
  python-opcua @ amd64:
    03.02.22 23:36:31 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ arm64:
    03.02.22 23:37:04 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ armhf:
    03.02.22 23:39:49 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ ppc64el:
    03.02.22 23:37:37 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅
  python-opcua @ s390x:
    03.02.22 23:36:10 Log 🗒️ ✅ Triggers: ['python-opcua/0.98.11-1ubuntu1~ppa1']
      basic-import-py3 PASS ✅

LGTM, +1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks Bryce, uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e3e45fe..2e4274d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+python-opcua (0.98.11-1ubuntu1) jammy; urgency=medium
7+
8+ * d/p/0005-fix-collections-import.patch: fix collections import for
9+ python 3.10+ (LP: #1959935)
10+
11+ -- Andreas Hasenack <andreas@canonical.com> Thu, 03 Feb 2022 20:22:48 +0000
12+
13 python-opcua (0.98.11-1) unstable; urgency=medium
14
15 * Team upload
16diff --git a/debian/control b/debian/control
17index 9ec8109..02e3d1f 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: python-opcua
22 Section: python
23 Priority: optional
24-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
27 Uploaders: W. Martin Borgert <debacle@debian.org>
28 Build-Depends: devscripts,
29 python3,
30diff --git a/debian/patches/0005-fix-collections-import.patch b/debian/patches/0005-fix-collections-import.patch
31new file mode 100644
32index 0000000..61ffa34
33--- /dev/null
34+++ b/debian/patches/0005-fix-collections-import.patch
35@@ -0,0 +1,35 @@
36+From 34d98f992f9f7e494be20f028cdf9a05b3b62540 Mon Sep 17 00:00:00 2001
37+From: Nick James <20824939+driftregion@users.noreply.github.com>
38+Date: Fri, 19 Jun 2020 03:56:17 +0800
39+Subject: [PATCH] remove DeprecationWarning: import Iterable from
40+ collections.abc if python >= 3.6 (#1075)
41+
42+Co-authored-by: Nick James <nick.james@dorabot.com>
43+---
44+ opcua/common/subscription.py | 6 +++++-
45+ 1 file changed, 5 insertions(+), 1 deletion(-)
46+
47+Origin: upstream, https://github.com/FreeOpcUa/python-opcua/commit/34d98f992f9f7e494be20f028cdf9a05b3b62540
48+Bug: https://github.com/FreeOpcUa/python-opcua/pull/1075
49+Bug-Debian: https://bugs.debian.org/1004937
50+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/python-opcua/+bug/1959935
51+Applied-Upstream: 0.98.12
52+Last-Update: 2022-02-03
53+
54+diff --git a/opcua/common/subscription.py b/opcua/common/subscription.py
55+index 19b8d1a8..defbafb0 100644
56+--- a/opcua/common/subscription.py
57++++ b/opcua/common/subscription.py
58+@@ -4,7 +4,11 @@
59+ import time
60+ import logging
61+ from threading import Lock
62+-from collections import Iterable
63++import sys
64++if sys.version_info.major == 3 and sys.version_info.minor >= 6:
65++ from collections.abc import Iterable
66++else:
67++ from collections import Iterable
68+
69+ from opcua import ua
70+ from opcua.common import events
71diff --git a/debian/patches/series b/debian/patches/series
72index 4cab713..f7e7f15 100644
73--- a/debian/patches/series
74+++ b/debian/patches/series
75@@ -1,3 +1,4 @@
76 add-shebang.patch
77 0003-Use-the-python3-binary-in-cmdline-tests.patch
78 0004-Fix-comparison-with-literal.patch
79+0005-fix-collections-import.patch

Subscribers

People subscribed via source and target branches