LGTM, not a super deep review but general approach looks good, and the patch checks out.
I've queued up tests in case they don't run via bileto:
$ lp-test-ppa ppa:ci-train-ppa-service/4818 --release jammy --showpass Tests for PPA 4818 ---- ---- ---- ---- Release: jammy Sources: SRC: postgresql-14 @ 14.2-1ubuntu1~ppa1 - Published Triggers on published Sources: postgresql-14 @ amd64 for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @amd64 ♻️ Trigger all proposed @amd64 ♻️ 💍 postgresql-14 @ s390x for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @s390x ♻️ Trigger all proposed @s390x ♻️ 💍 postgresql-14 @ ppc64el for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @ppc64el ♻️ Trigger all proposed @ppc64el ♻️ 💍 postgresql-14 @ arm64 for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @arm64 ♻️ Trigger all proposed @arm64 ♻️ 💍 postgresql-14 @ armhf for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @armhf ♻️ Trigger all proposed @armhf ♻️ 💍 postgresql-14 @ riscv64 for postgresql-14/14.2-1ubuntu1~ppa1 Trigger @riscv64 ♻️ Trigger all proposed @riscv64 ♻️ 💍 Results from https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4818/?format=plain: No results published yet Running: time pkg release arch ppa trigger 0:02:50 postgresql-14 jammy arm64 ci-train-ppa-service/4818 postgresql-14/14.2-1ubuntu1~ppa1 0:07:10 postgresql-14 jammy armhf ci-train-ppa-service/4818 postgresql-14/14.2-1ubuntu1~ppa1 0:09:00 postgresql-14 jammy s390x ci-train-ppa-service/4818 postgresql-14/14.2-1ubuntu1~ppa1 0:09:50 postgresql-14 jammy amd64 ci-train-ppa-service/4818 postgresql-14/14.2-1ubuntu1~ppa1 Waiting: Q-num pkg release arch ppa trigger 1 postgresql-14 jammy ppc64el ci-train-ppa-service/4818 postgresql-14/14.2-1ubuntu1~ppa1
Assuming those pass, I think this looks good.
« Back to merge proposal
LGTM, not a super deep review but general approach looks good, and the patch checks out.
I've queued up tests in case they don't run via bileto:
$ lp-test-ppa ppa:ci- train-ppa- service/ 4818 --release jammy --showpass
postgresql- 14 @ amd64 for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @amd64 ♻️ Trigger all proposed @amd64 ♻️ 💍
postgresql- 14 @ s390x for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @s390x ♻️ Trigger all proposed @s390x ♻️ 💍
postgresql- 14 @ ppc64el for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @ppc64el ♻️ Trigger all proposed @ppc64el ♻️ 💍
postgresql- 14 @ arm64 for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @arm64 ♻️ Trigger all proposed @arm64 ♻️ 💍
postgresql- 14 @ armhf for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @armhf ♻️ Trigger all proposed @armhf ♻️ 💍
postgresql- 14 @ riscv64 for postgresql- 14/14.2- 1ubuntu1~ ppa1 Trigger @riscv64 ♻️ Trigger all proposed @riscv64 ♻️ 💍 /autopkgtest. ubuntu. com/results/ autopkgtest- jammy-ci- train-ppa- service- 4818/?format= plain: ppa-service/ 4818 postgresql- 14/14.2- 1ubuntu1~ ppa1 ppa-service/ 4818 postgresql- 14/14.2- 1ubuntu1~ ppa1 ppa-service/ 4818 postgresql- 14/14.2- 1ubuntu1~ ppa1 ppa-service/ 4818 postgresql- 14/14.2- 1ubuntu1~ ppa1 ppa-service/ 4818 postgresql- 14/14.2- 1ubuntu1~ ppa1
Tests for PPA 4818
---- ---- ---- ----
Release: jammy
Sources:
SRC: postgresql-14 @ 14.2-1ubuntu1~ppa1 - Published
Triggers on published Sources:
Results from https:/
No results published yet
Running:
time pkg release arch ppa trigger
0:02:50 postgresql-14 jammy arm64 ci-train-
0:07:10 postgresql-14 jammy armhf ci-train-
0:09:00 postgresql-14 jammy s390x ci-train-
0:09:50 postgresql-14 jammy amd64 ci-train-
Waiting:
Q-num pkg release arch ppa trigger
1 postgresql-14 jammy ppc64el ci-train-
Assuming those pass, I think this looks good.