Ubuntu
openldap package

Code review comment for ~ahasenack/ubuntu/+source/openldap:xenial-slapd-sasl-segfault-1688575

  1. Git
  2. lp:~ahasenack/ubuntu/+source/openldap
  3. xenial-slapd-sasl-segfault-1688575
  4. Merge into ubuntu/xenial-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog: ok
Test and verification: ok
ppa fixing the bug: ok
ppa build has no other obvious issues: ok
Review changes: notes, see below

Note: I added the needed dependencies to the SRU template of your bug

I'd ask you to add a bit more to the dep3 headers, in particular a Origin with an URL.
I know your git exports files hold the sha, and if one knows the openldap repo he might find it.
But a real URL that gets you to the change would really be preferred.

Further we usually do a back-ref of the "Ubuntu-Bug: ..." from the .patch files to the bug number right? That would help to later maintain this more easily as well.

Finally the changelog doesn't refer to the .patch files. This last statement might be personal-style and not required - up to you.

review: Needs Fixing

« Back to merge proposal