Code review comment for ~ahasenack/ubuntu/+source/nfs-utils:jammy-nfs-utils-merge
Revision history for this message
| Andreas Hasenack (ahasenack) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> For the NEWS entry, since the regex plugin is effectively a new feature, maybe it's not as
> necessary to explain why it was omitted,
Hm, interesting point. I wanted to explain somewhere why we are the only ones who ship nfs-utils without this plugin. I even had to patch the idmapd.conf.5 manpage to point at the package in universe. Maybe README.Debian is more appropriate then?
> Does the libnfsidmap-regex package provide man page info similar to what's being dropped with
> this merge?
Yes. It has an extra bit about two different config keys (Group-Map-File and Group-Map-Section) but I couldn't find evidence in the code that they exist, nor could I get them to work. They are not mentioned in the nfs-utils' idmapd.conf.5 manpage.
My patch for nfsutils' idmapd.conf.5 mentions the other manpage in the regex package, called libnfsidmap-
> Do you think it would be worthwhile to mention the nfsconvert.py script in the section of the
> NEWS file explaining the config changes,
This script is not part of the upstream source, it's a script made by Fedora and shipped only in their package. If we decide to involve that script somehow, then it will for sure be mentioned in NEWS and probably also README.Debian.
About apport, good catch, I had forgotten about that. I need to update the debian/*.bug-script files to use /etc/nfs.conf too. I'm not sure if apport uses those, but a bug is the right place to check. bug #1961058