Ubuntu
libpmemobj-cpp package

Code review comment for ~ahasenack/ubuntu/+source/libpmemobj-cpp:eoan-libpmemobj-cpp-merge-1.6

  1. Git
  2. lp:~ahasenack/ubuntu/+source/libpmemobj-cpp
  3. eoan-libpmemobj-cpp-merge-1.6
  4. Merge into debian/experimental
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Not sure on the plural of this, maybe:
"This is the HTML docs" -> "These are the HTML docs"

The transition changes look as we created them for 1.5 - ack
The doc fixups in general look correct to me and those are submittable to Debian.

The other changes we have discussed on the 1.5 merge already and they are retained correctly IMHO.
I'm interested to hear what Debian said about:
-Architecture: any
+Architecture: amd64
Let me know that when you have feedback.

Overall LGTM +1

review: Approve

« Back to merge proposal