Merge ~ahasenack/ubuntu/+source/libcloud:more-dep8-fixes into ~ahasenack/ubuntu/+source/libcloud:master

Proposed by Andreas Hasenack
Status: Superseded
Proposed branch: ~ahasenack/ubuntu/+source/libcloud:more-dep8-fixes
Merge into: ~ahasenack/ubuntu/+source/libcloud:master
Diff against target: 64 lines (+43/-0) (has conflicts)
3 files modified
debian/changelog (+10/-0)
debian/patches/convert-object-size.patch (+29/-0)
debian/patches/series (+4/-0)
Conflict in debian/changelog
Conflict in debian/patches/series
Reviewer Review Type Date Requested Status
Canonical Server MOTU reviewers Pending
Canonical Server Pending
Review via email: mp+353989@code.launchpad.net

Description of the change

This adds the remaining test fix that was accepted upstream.

Bileto ticket: https://bileto.ubuntu.com/#/ticket/3392

All libcloud tests are green now.

Again the target branch is just my own, since git-ubuntu fails to import libcloud. I did a gbp import of the current cosmic package and based my branch on that.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hmm the MP here is "superseded" so you gave up and will try new with another approach?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

It has conflicts because of the old master. I pushed again and made a new
mp, there should be a new link

On Thu, Aug 30, 2018, 02:12  Christian Ehrhardt  <
<email address hidden>> wrote:

> Hmm the MP here is "superseded" so you gave up and will try new with
> another approach?
>
> --
>
> https://code.launchpad.net/~ahasenack/ubuntu/+source/libcloud/+git/libcloud/+merge/353989
> You are the owner of ~ahasenack/ubuntu/+source/libcloud:more-dep8-fixes.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: ahasenack
> Launchpad-Notification-Type: code-review
> Launchpad-Branch:
> ~ahasenack/ubuntu/+source/libcloud/+git/libcloud:more-dep8-fixes
>

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This is the correct one, and it shows up in the queue:
https://code.launchpad.net/~ahasenack/ubuntu/+source/libcloud/+git/libcloud/+merge/353991

On Thu, Aug 30, 2018, 06:34 Andreas Hasenack <email address hidden> wrote:

> It has conflicts because of the old master. I pushed again and made a new
> mp, there should be a new link
>
> On Thu, Aug 30, 2018, 02:12  Christian Ehrhardt  <
> <email address hidden>> wrote:
>
> > Hmm the MP here is "superseded" so you gave up and will try new with
> > another approach?
> >
> > --
> >
> >
> https://code.launchpad.net/~ahasenack/ubuntu/+source/libcloud/+git/libcloud/+merge/353989
> > You are the owner of ~ahasenack/ubuntu/+source/libcloud:more-dep8-fixes.
> >
> > Launchpad-Message-Rationale: Owner
> > Launchpad-Message-For: ahasenack
> > Launchpad-Notification-Type: code-review
> > Launchpad-Branch:
> > ~ahasenack/ubuntu/+source/libcloud/+git/libcloud:more-dep8-fixes
> >
>
> --
>
> https://code.launchpad.net/~ahasenack/ubuntu/+source/libcloud/+git/libcloud/+merge/353989
> You are the owner of ~ahasenack/ubuntu/+source/libcloud:more-dep8-fixes.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: ahasenack
> Launchpad-Notification-Type: code-review
> Launchpad-Branch:
> ~ahasenack/ubuntu/+source/libcloud/+git/libcloud:more-dep8-fixes
>

Unmerged commits

4d77dd0... by Andreas Hasenack

changelog

3151ed4... by Andreas Hasenack

  * d/p/convert-object-size.patch: Convert object_size to string before
    adding it to a header.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 21094b4..c96577e 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,13 @@
6+<<<<<<< debian/changelog
7+=======
8+libcloud (2.3.0-1ubuntu2) cosmic; urgency=medium
9+
10+ * d/p/convert-object-size.patch: Convert object_size to string before
11+ adding it to a header.
12+
13+ -- Andreas Hasenack <andreas@canonical.com> Wed, 29 Aug 2018 10:10:47 -0300
14+
15+>>>>>>> debian/changelog
16 libcloud (2.3.0-1ubuntu1) cosmic; urgency=medium
17
18 * Address some python 3.7 issues (LP: #1788931):
19diff --git a/debian/patches/convert-object-size.patch b/debian/patches/convert-object-size.patch
20new file mode 100644
21index 0000000..bf2813c
22--- /dev/null
23+++ b/debian/patches/convert-object-size.patch
24@@ -0,0 +1,29 @@
25+Description: Convert object_size to string before adding it to a header.
26+ Since python-requests 2.11
27+ (see https://github.com/requests/requests/issues/3477), integer values
28+ in headers are no longer automatically converted to strings, so we need
29+ to do it ourselves.
30+ .
31+ This is the same change that was done a couple of lines above for the
32+ Content-Length header in commit 28a559042.
33+ .
34+ Signed-off-by: Quentin Pradet <quentinp@apache.org>
35+Author: Andreas Hasenack <andreas@canonical.com>
36+Bug: https://github.com/apache/libcloud/pull/1237
37+Applied-Upstream: https://github.com/apache/libcloud/commit/e77580d8e0bfacf95e68210448186af4b9109025
38+Last-Update: 2018-08-29
39+---
40+ libcloud/storage/drivers/azure_blobs.py | 2 +-
41+ 1 file changed, 1 insertion(+), 1 deletion(-)
42+
43+--- a/libcloud/storage/drivers/azure_blobs.py
44++++ b/libcloud/storage/drivers/azure_blobs.py
45+@@ -865,7 +865,7 @@
46+
47+ if blob_type == 'PageBlob':
48+ headers['Content-Length'] = str('0')
49+- headers['x-ms-blob-content-length'] = object_size
50++ headers['x-ms-blob-content-length'] = str(object_size)
51+
52+ return headers
53+
54diff --git a/debian/patches/series b/debian/patches/series
55index b272d4c..25f5cee 100644
56--- a/debian/patches/series
57+++ b/debian/patches/series
58@@ -1,2 +1,6 @@
59 remove-async-due-py37.patch
60 handle-http_proxy-in-tests.patch
61+<<<<<<< debian/patches/series
62+=======
63+convert-object-size.patch
64+>>>>>>> debian/patches/series

Subscribers

People subscribed via source and target branches

to all changes: