Merge ~ahasenack/ubuntu/+source/libapache2-mod-perl2:xenial-modperl2-fix-dep8-1779400 into ubuntu/+source/libapache2-mod-perl2:ubuntu/xenial-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robie Basak | ||||
Approved revision: | afe63fa602ff94b2a8645ca156d7d44253112b2e | ||||
Merge reported by: | Christian Ehrhardt | ||||
Merged at revision: | afe63fa602ff94b2a8645ca156d7d44253112b2e | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/libapache2-mod-perl2:xenial-modperl2-fix-dep8-1779400 | ||||
Merge into: | ubuntu/+source/libapache2-mod-perl2:ubuntu/xenial-devel | ||||
Diff against target: |
121 lines (+93/-0) 4 files modified
debian/changelog (+11/-0) debian/patches/370_http_syntax.patch (+34/-0) debian/patches/380_inject_header_line_terminators.patch (+46/-0) debian/patches/series (+2/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+348780@code.launchpad.net |
Description of the change
PPA with test packages: https:/
This branch brings to xenial the Debian DEP8 fixes from libapache2-
I slightly augmented the two patches with a reference to the Ubuntu bug, but that's it.
The two test failures we are fixing here are:
t/apache/read.t (Wstat: 0 Tests: 1 Failed: 1)
Failed test: 1
t/filter/
Non-zero exit status: 2
Parse errors: Bad plan. You planned 36 tests but ran 0.
Here is the xenial/amd64 test history: http://
Run this to verify the fix and run the dep8 tests locally (adjust the path to the xenial autopkgtest image):
autopkgtest -o dep8-xenial-ppa -U -s --apt-pocket=
Here is an output run with the package from the test ppa: http://
Thanks for adding the Bug refs, from a packaging POV this LGTM.
It leaves open the convincing of the SRU Team to push an update for it, but I think it might be ok.
Worst case they will ask you to do a force-badtest hint, but then the coverage of the tests would be lost and since you have the fix ready, why not.
Two minor comments that you might include if you want (maybe only in the bug for the second). 2.4.18- 2ubuntu3. 9 it seems - I assume that some security update might have brought the changes in, it might be worth to find what exactly and mention it in the changelog/ patch-headers
- this is a chain of thanks, you mention Niko, and in the Debian change he mentions Stefan Fritsch.
Not sure, but if you want to update you might want to mention the original Author instead of the
Debian packager?
- The Bug and Comments mention this is a compat needed for 2.4.24 but Xenial has apache2/