Ubuntu
libapache2-mod-perl2 package

Code review comment for ~ahasenack/ubuntu/+source/libapache2-mod-perl2:xenial-modperl2-fix-dep8-1779400

  1. Git
  2. lp:~ahasenack/ubuntu/+source/libapache2-mod-perl2
  3. xenial-modperl2-fix-dep8-1779400
  4. Merge into ubuntu/xenial-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for adding the Bug refs, from a packaging POV this LGTM.

It leaves open the convincing of the SRU Team to push an update for it, but I think it might be ok.
Worst case they will ask you to do a force-badtest hint, but then the coverage of the tests would be lost and since you have the fix ready, why not.

Two minor comments that you might include if you want (maybe only in the bug for the second).
- this is a chain of thanks, you mention Niko, and in the Debian change he mentions Stefan Fritsch.
  Not sure, but if you want to update you might want to mention the original Author instead of the
  Debian packager?
- The Bug and Comments mention this is a compat needed for 2.4.24 but Xenial has apache2/2.4.18-2ubuntu3.9 it seems - I assume that some security update might have brought the changes in, it might be worth to find what exactly and mention it in the changelog/patch-headers

review: Approve

« Back to merge proposal