© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Sorry this review took a while (well from your POV it might have been over-night no matter how long it took :-) ).
Generally looks good already, a few requests for info or changes at the bottom of this.
Changelog:
- [√] old content matches Debian
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [√] update-maintainer has been run
Actual changes:
- [√] upstream changes look ok
I have double checked the orig-tarball without an import yet
I compared your PPA vs upstream vs git and they match.
- [√] no further upstream version to consider (1.7 is dev, ok to take 1.6)
- [√] no "new" debian changes to consider as we don't merge but go ahead
Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop
- [√] changes forwarded to debian (I know you are in contact, let that be enough for now)
New Delta:
- [√] I went through the new changes one by one and they seem ok, some feedback detail below
Build/Test:
- [√] build is ok, but x86 only
- [√] verified PPA package installs/uninstalls
- [√] autopkgtest against the PPA package passes
- [√] sanity checks test fine
TODOs:
- the bugs 1858347 and 1809262 need to be mentioned in the changelog
- This is "Architecture: any" but I see only amd64 test builds, before a final upload probably better also test cross arch build?
- debian/
- for "enable generate messages" the reasoning seems off, when reading
https:/
https:/
It seems a better reason would be "to re-generate docs on build" or something like it.
If we have another reason we should mention that one
- --enable-perfdhcp: why is it default off is it known to be broken or bad in anyway?
I found upstream 8ee2c24be138381
If you know a reason please add it.
- your PPAs seem to have proposed disabled I see in buildlog libboost-