Code review comment for ~ahasenack/ubuntu/+source/haproxy:disco-haproxy-better-dep8

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Generally a simple but quite useful test, thanks for adding that.
I'm nit-picking and leave it to you what you want to fix - it is "good enough" to go as-is if that is what you prefer.

On the question to add the test on SRU.
IMHO the tradeoff usually is:
- do not add flaky tests (this one seems stable)
- do not SRU for just a test as we trigger many downloads around the world (here we SRU the fix anyway)
=> Therefore if it is not too much effort (e.g. the config would be vastly different on older versions) I'd lean to adding the test on the SRUs as well.

review: Needs Information

« Back to merge proposal