Merge ~ahasenack/ubuntu/+source/git:lunar-git-cpuinfo-regexp into ubuntu/+source/git:ubuntu/devel

Proposed by Andreas Hasenack
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Andreas Hasenack
Merged at revision: 57f47d6dbc8cd1f7576073b945385659951e55b8
Proposed branch: ~ahasenack/ubuntu/+source/git:lunar-git-cpuinfo-regexp
Merge into: ubuntu/+source/git:ubuntu/devel
Diff against target: 49 lines (+29/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-cpuinfo-regexp.patch (+21/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Sergio Durigan Junior (community) Approve
Canonical Server Reporter Pending
Review via email: mp+433461@code.launchpad.net

Description of the change

Adjust the regexp to cope with how processors are described in /proc/cpuinfo in s390x. The bug has details.

PPA (still building, but a manual build I did in an s390x VM confirmed the fix):

https://launchpad.net/~ahasenack/+archive/ubuntu/git-ftbfs-cpuinfo

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Andreas.

The patch LGTM, and I see that upstream also likes the approach. The build is still pending on the PPA, so I'm +1 assuming that the build succeeds.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: ahasenack, sergiodj
Uploaders: ahasenack, sergiodj
MP auto-approved

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, the build succeeded, uploading.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Uploading git_2.38.1-1ubuntu2.dsc
Uploading git_2.38.1-1ubuntu2.debian.tar.xz
Uploading git_2.38.1-1ubuntu2_source.buildinfo
Uploading git_2.38.1-1ubuntu2_source.changes

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This is in lunar-proposed already, and the branch was merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 3b0b6ce..0e94e4a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1git (1:2.38.1-1ubuntu2) lunar; urgency=medium
2
3 * d/p/fix-cpuinfo-regexp.patch: fix cpuinfo regexp to accomodate the
4 way s390x shows it (LP: #1997475)
5
6 -- Andreas Hasenack <andreas@canonical.com> Tue, 22 Nov 2022 14:25:40 -0300
7
1git (1:2.38.1-1ubuntu1) lunar; urgency=low8git (1:2.38.1-1ubuntu1) lunar; urgency=low
29
3 * Merge from Debian unstable. Remaining changes:10 * Merge from Debian unstable. Remaining changes:
diff --git a/debian/patches/fix-cpuinfo-regexp.patch b/debian/patches/fix-cpuinfo-regexp.patch
4new file mode 10064411new file mode 100644
index 0000000..3b7cf79
--- /dev/null
+++ b/debian/patches/fix-cpuinfo-regexp.patch
@@ -0,0 +1,21 @@
1Description: adjust /proc/cpuinfo for s390x
2 In s390x, the ^processor line is like this:
3 processor 0: version = FF, identification = 148F67, machine = 2964
4Author: Andreas Hasenack <andreas@canonical.com>
5Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024653
6Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/git/+bug/1997475
7Forwarded: https://public-inbox.org/git/CANYNYEHXU8ivgAOa8EO5e9kOcbu6XF7rj+9EcSrbDQE+Rvyw_Q@mail.gmail.com/T/#u
8Last-Update: 2022-11-22
9diff --git a/t/chainlint.pl b/t/chainlint.pl
10index 976db4b8a0..2bbac1ebd7 100755
11--- a/t/chainlint.pl
12+++ b/t/chainlint.pl
13@@ -656,7 +656,7 @@ sub ncores {
14 # Windows
15 return $ENV{NUMBER_OF_PROCESSORS} if exists($ENV{NUMBER_OF_PROCESSORS});
16 # Linux / MSYS2 / Cygwin / WSL
17- do { local @ARGV='/proc/cpuinfo'; return scalar(grep(/^processor\s*:/, <>)); } if -r '/proc/cpuinfo';
18+ do { local @ARGV='/proc/cpuinfo'; return scalar(grep(/^processor[\s\d]*:/, <>)); } if -r '/proc/cpuinfo';
19 # macOS & BSD
20 return qx/sysctl -n hw.ncpu/ if $^O =~ /(?:^darwin$|bsd)/;
21 return 1;
diff --git a/debian/patches/series b/debian/patches/series
0new file mode 10064422new file mode 100644
index 0000000..4bfb379
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
1fix-cpuinfo-regexp.patch

Subscribers

People subscribed via source and target branches