Code review comment for ~ahasenack/ubuntu/+source/frr:kinetic-frr-logging-2

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hi Evren,

thanks for your suggestion. If I understand it correctly, you are suggesting to ask debian to change /var/log/frr from frr:frr 0750 to frr:adm 0770? Or 2770?

I think for debian the "create" logrotate config would still be needed, or else the new frr.log file would be created with rsyslog's defaults there which are root:adm (from /etc/rsyslog.conf), even with the sgid bit set in /var/log/frr.

« Back to merge proposal