Code review comment for ~ahasenack/ubuntu/+source/frr:kinetic-frr-logging-2

Hi Andreas,

Would it not be better to not force specific ownerships in `frr.logrotate`? I mean this line:

create 640 syslog adm

If this line is missing, it will default to correct username which is syslog. (as rsyslogd is running as syslog)

The folder /var/log/frr could have 0770 permissions and ownership should be `frr:adm`. The default /etc/rsyslog.conf configuration should cause files to be created with `syslog:adm` ownership.

I believe this way, perhaps a `delta` can be avoided. Debian already has accepted similar changes for `tomcat9` package as the directory is owned by `tomcat:adm` with 2770 permissions.

Thanks,
Evren