Merge ~ahasenack/ubuntu/+source/freeradius:oracular-freeradius-replace-radsecret into ubuntu/+source/freeradius:ubuntu/devel
Status: | Merged |
---|---|
Approved by: | git-ubuntu bot |
Approved revision: | not available |
Merged at revision: | 4b70aa177d67f3a828ff0a4945f1bf0ca4cd43e1 |
Proposed branch: | ~ahasenack/ubuntu/+source/freeradius:oracular-freeradius-replace-radsecret |
Merge into: | ubuntu/+source/freeradius:ubuntu/devel |
Diff against target: |
82 lines (+39/-3) 4 files modified
debian/changelog (+11/-0) debian/control (+2/-3) debian/patches/replace-radsecret.patch (+25/-0) debian/patches/series (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
git-ubuntu bot | Approve | ||
Mitchell Dzurick (community) | Approve | ||
Canonical Server Core Reviewers | Pending | ||
Canonical Server Reporter | Pending | ||
Review via email:
|
Description of the change
Replace the radsecret perl script with a bash variant to avoid pulling in two new perl dependencies which are in universe and would trigger a component mismatch.
The bug also has two other python suggestions, but I think this is simpler, bar any glaring security vulnerability. I did ask #security internally for a quick check, Got one +1, waiting on another.
Upstream also suggested in our bug to just drop this script, as it's not used internally by anything else, so that's also an option.
The tools I used in the script (base32, td, dd) are in the coreutils package, which is of priority "required", so no new dependency has to be added to the package.
PPA building at https:/
Reading the perl function[0] there is error messages indicating checking that enough randomness was gathered (RtlGenRand failed).
/dev/urandom does guarantee non-blocking data, so this should be fine. I just want to point out there is a potential of missing some checks from the perl library, but in this case it should be safe to rely on the device for providing enough data.
[0] - https:/ /manpages. debian. org/testing/ libcrypt- urandom- perl/Crypt: :URandom. 3pm.en. html