Code review comment for ~ahasenack/ubuntu/+source/cyrus-sasl2:kinetic-sasl2-digestmd5-noise

Revision history for this message
Bryce Harrington (bryce) wrote :

Some inline discussion but mostly me talking to myself, nothing that really has to be changed.

I'm not sure how this is enacted in the client, but I noticed you asked that question and got an answer, and you've tested thoroughly enough to confirm it does behave as expected in practice, so presumably you're confident it's being enacted properly.

Everything LGTM, +1.

Results from https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-ahasenack-sasl-verbose-digestmd5/?format=plain:
  cyrus-sasl2 @ arm64:
    27.05.22 18:52:51 Log 🗒️ ✅ Triggers: ['cyrus-sasl2/2.1.28+dfsg-6ubuntu1~ppa1']
      pluginviewer PASS ✅
      saslauthd PASS ✅
      gssapi PASS ✅
      shared-secret-mechs PASS ✅
  cyrus-sasl2 @ armhf:
    27.05.22 18:54:57 Log 🗒️ ✅ Triggers: ['cyrus-sasl2/2.1.28+dfsg-6ubuntu1~ppa1']
      pluginviewer PASS ✅
      saslauthd PASS ✅
      gssapi PASS ✅
      shared-secret-mechs PASS ✅
  cyrus-sasl2 @ ppc64el:
    27.05.22 18:43:38 Log 🗒️ ✅ Triggers: ['cyrus-sasl2/2.1.28+dfsg-6ubuntu1~ppa1']
      pluginviewer PASS ✅
      saslauthd PASS ✅
      gssapi PASS ✅
      shared-secret-mechs PASS ✅
  cyrus-sasl2 @ s390x:
    27.05.22 18:42:11 Log 🗒️ ✅ Triggers: ['cyrus-sasl2/2.1.28+dfsg-6ubuntu1~ppa1']
      pluginviewer PASS ✅
      saslauthd PASS ✅
      gssapi PASS ✅
      shared-secret-mechs PASS ✅
Running:
    time pkg release arch ppa trigger
    0:23:22 cyrus-sasl2 kinetic amd64 ahasenack/sasl-verbose-digestmd5 cyrus-sasl2/2.1.28+dfsg-6ubuntu1~ppa1
Waiting:

review: Approve

« Back to merge proposal